feat: preview template payload on hover in Manual Run trigger#4447
Open
coffeenjoyer17 wants to merge 1 commit intosuperplanehq:mainfrom
Open
feat: preview template payload on hover in Manual Run trigger#4447coffeenjoyer17 wants to merge 1 commit intosuperplanehq:mainfrom
coffeenjoyer17 wants to merge 1 commit intosuperplanehq:mainfrom
Conversation
Wraps each Manual Run template row in PayloadTooltip so users can hover the template name to see its configured payload as a formatted JSON popover, matching the preview pattern already used for component spec metadata. Helps when several templates share similar names or when verifying inputs before clicking Run. Closes superplanehq#2810 Signed-off-by: coffeenjoyer17 <pufleacristian56@gmail.com>
|
👋 Commands for maintainers:
|
superplane-policy-bot
Bot
requested review from
forestileao,
lucaspin and
shiroyasha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2810
Summary
Manual Run templates currently surface only their name and a Run button. When several templates share similar names (or when a user is just verifying before triggering), there is no way to confirm the payload short of opening the configuration. This PR adds a hover preview on the template row that shows the configured payload as formatted JSON.
Implementation
PayloadTooltip(the same component already used to surface component spec previews inui/componentBase/index.tsx).cursor-helpclass on the wrapped area so the affordance is discoverable.data-testid="start-template-row"added on the wrapped row for future tests.Notes
PayloadTooltipis the existing pattern (Tippy + Monaco).PayloadTooltip) prevents accidental triggers from neighbouring hovers.tsc --noEmitclean.npm run lint:budgettotals are unchanged frommain(the pre-existingreact-refresh/only-export-componentsandmax-linesbudgets are over before this change too).