Fix: First Commit Win guarantee may be broken under high concurrency#378
Open
xuerongNanopay wants to merge 2 commits intosurrealdb:mainfrom
Open
Fix: First Commit Win guarantee may be broken under high concurrency#378xuerongNanopay wants to merge 2 commits intosurrealdb:mainfrom
xuerongNanopay wants to merge 2 commits intosurrealdb:mainfrom
Conversation
Contributor
|
Sorry for the delay in merging this. LGTM. I'll run some benchmarks and confirm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request. We really appreciate you spending the time to work on SurrealDB. 🚀 🎉
What is the motivation?
The first-committer-wins guarantee may be broken under high concurrency.
The root cause is that the write-write conflict check doesn't not operate under serialization manner.
What does this change do?
validate_write_conflictsmethod intoCommitEnvtrait.batch.starting_seq_numto storevisible_seq_numforvalidate_write_conflictsinitially, and will be updated to log sequence number before write to WALWhat is your testing strategy?
Run tests in my local. All passed.
Is this related to any issues?
#376
Does this change need documentation?
Does this change make any alterations to environment variables or CLI commands?
Have you read the Contributing Guidelines?