Skip to content

bump to go v1.26 #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
synfinatic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bump to go v1.26 #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ DESCRIPTION := AWS SSO CLI
BUILDINFOS ?= $(shell date +%FT%T%z)$(BUILDINFOSDET)
LDFLAGS := -X "main.Version=$(PROJECT_VERSION)" -X "main.Delta=$(PROJECT_DELTA)" -X "main.Buildinfos=$(BUILDINFOS)" -X "main.Tag=$(PROJECT_TAG)" -X "main.CommitID=$(PROJECT_COMMIT)"
OUTPUT_NAME := $(DIST_DIR)$(PROJECT_NAME)-$(PROJECT_VERSION) # default for current platform
GOLANG_CILINT_VERSION := 2.10.1

#ifeq ($(GOOS),darwin)
# https://github.com/golang/go/issues/61229#issuecomment-1988965927
Expand Down Expand Up @@ -188,9 +189,20 @@ test-tidy: ## Test to make sure go.mod is tidy
exit -1 ; \
fi

lint: ## Run golangci-lint
lint: .lint-check ## Run golangci-lint
golangci-lint run

lint-install: ## Install golangci-lint
curl -sSfL https://golangci-lint.run/install.sh | sh -s -- -b $(go env GOPATH)/bin v$(GOLANG_CILINT_VERSION)

.lint-check:
if test $$(golangci-lint --version 2>&1 | grep -c "version $(GOLANG_CILINT_VERSION)") -eq 0 ; then \
echo "Need to install golangci-lint $(GOLANG_CILINT_VERSION)" ; \
echo "Run: make lint-install" ; \
exit -1 ; \
fi


test-homebrew: $(DIST_DIR)$(PROJECT_NAME) ## Run the homebrew tests
@$(DIST_DIR)$(PROJECT_NAME) --config /dev/null version 2>/dev/null | grep -q "AWS SSO CLI Version $(PROJECT_VERSION)"
@$(DIST_DIR)$(PROJECT_NAME) --config /dev/null 2>&1 | grep -q "no AWS SSO providers have been configured"
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/synfinatic/aws-sso-cli

go 1.23.0
go 1.26.0

toolchain go1.23.6
// toolchain go1.23.6

require (
github.com/99designs/keyring v1.2.2
Expand Down
Loading