fix: bump aws-sdk-go-v2 SDKs for AWS European Sovereign Cloud (EUSC) support#1309
Open
nlang wants to merge 1 commit intosynfinatic:mainfrom
Open
fix: bump aws-sdk-go-v2 SDKs for AWS European Sovereign Cloud (EUSC) support#1309nlang wants to merge 1 commit intosynfinatic:mainfrom
nlang wants to merge 1 commit intosynfinatic:mainfrom
Conversation
…support
The AWS European Sovereign Cloud uses the `aws-eusc` partition with a
distinct DNS suffix (`amazonaws.eu`), and regions named `eusc-de-east-1`,
etc. The previously vendored versions of `service/sso` (v1.22.1) and
`service/ssooidc` (v1.26.2) predate that partition and fall back to the
default `amazonaws.com` suffix, producing DNS lookup failures such as:
dial tcp: lookup oidc.eusc-de-east-1.amazonaws.com: no such host
dial tcp: lookup portal.sso.eusc-de-east-1.amazonaws.com: no such host
Bumping `service/sso` to v1.30.16 and `service/ssooidc` to v1.35.20
introduces the partition entry and the correct hostnames
(`oidc.{region}.amazonaws.eu`, `portal.sso.{region}.amazonaws.eu`).
Required transitive bumps: `aws-sdk-go-v2` core, `internal/configsources`,
`internal/endpoints/v2`, `smithy-go`. The new SDK modules require Go 1.24,
so the `go` directive is raised accordingly.
No code changes are needed: SSO/OIDC clients are already constructed with
just the region, and the partition/endpoint resolution is handled by the
SDK once the partition is known.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service/ssov1.22.1 → v1.30.16 andservice/ssooidcv1.26.2 → v1.35.20 (plus required transitiveaws-sdk-go-v2core /smithy-go/internal/configsources/internal/endpoints/v2bumps).aws-euscpartition with the correct DNS suffixamazonaws.euand the regex^eusc-(de)-\w+-\d+$. Without it, the SDK falls back toamazonaws.comand DNS resolution for EUSC endpoints (e.g.oidc.eusc-de-east-1.amazonaws.com) fails.godirective ingo.modis raised from 1.23 to 1.24.ssooidc.New(...)/sso.New(...)already let the SDK resolve the partition from the region.Motivation
End users in the EU Sovereign Cloud (region
eusc-de-east-1) currently hit:because the vendored SDKs predate the
aws-euscpartition.Test plan
go build ./...cleango test ./...all packages passgo vet ./...cleanRegisterClientandStartDeviceAuthorizationagainsteusc-de-east-1now resolve to*.amazonaws.euand the device authorization flow completes.Note on Go version
go.modis bumped togo 1.24because the upgraded SDK modules declare it as their minimum. Ifvars.GO_VERSIONin CI is still below 1.24, it will need to be raised together with this change.