feat(scoring): expose merged scorer output#3
Draft
ovitrif wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2.
This PR adds the small write/merge surface needed by
scorer-devkit-style tooling after the diagnostics API from #2:ChannelLiquidities::merge(...)for offline tools that read multiple serialized scorer files, decay them to a shared timestamp, merge overlapping entries with LDK per-channel semantics, preserve unique entries, and write the resultingChannelLiquiditiesback out.CombinedScorer::scores()for callers that use the existingCombinedScorer::merge(...)path and then need to explicitly serialize the in-memory combined scorer state. This intentionally differs fromCombinedScorer'sWriteableimpl, which still persists local-only scores.This keeps the existing runtime persistence behavior unchanged while exposing enough for an external CLI to build a merged score file.
Test plan
cargo test -p lightning --lib routing::scoring::tests::