fix: resolve RecursionError for self-referencing schemas#306
Open
mojixcoder wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
resolve_schema_references() would raise a RecursionError when the OpenAPI schema contained a self-referencing (recursive) Pydantic model — e.g. a CompoundFilter that contains a list of CompoundFilter | ComparisonFilter.
Root cause: The function unconditionally expanded every $ref it encountered, including back-references to a schema already being expanded, leading to infinite recursion.
Fix: Added a _visited parameter (a frozenset of $ref paths currently on the expansion stack). When a $ref is encountered that is already in _visited, the function returns the $ref in place rather than expanding it, breaking the cycle.
Test: Added test_self_referencing_schema_does_not_raise_recursion_error with a minimal recursive model (CompoundFilter → List[ComparisonFilter | CompoundFilter]) to guard against regressions.
Issue ticket number and link (if applicable)
Clsoes #287
Screenshots of the feature / bugfix
Checklist before requesting a review
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.