Quality: getFileId extracts incorrect file ID for multi-dot filenames#638
Open
kumburovicbranko682-boop wants to merge 1 commit into
Conversation
…ilenames
`split(".")[0]` takes everything before the *first* dot, not before the last dot (the extension). For a filename like `widget.v2.stories.tsx`, this returns `widget` instead of `widget.v2`. Two files `widget.v1.stories.tsx` and `widget.v2.stories.tsx` would produce the same file ID, causing a spurious duplicate story ID error from `detectDuplicateStoryNames` even though the filenames are legitimately different. This is a silent correctness bug in the naming pipeline.
Affected files: naming-utils.js
Signed-off-by: kumburovicbranko682-boop <295886834+kumburovicbranko682-boop@users.noreply.github.com>
LucaCorcella
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
split(".")[0]takes everything before the first dot, not before the last dot (the extension). For a filename likewidget.v2.stories.tsx, this returnswidgetinstead ofwidget.v2. Two fileswidget.v1.stories.tsxandwidget.v2.stories.tsxwould produce the same file ID, causing a spurious duplicate story ID error fromdetectDuplicateStoryNameseven though the filenames are legitimately different. This is a silent correctness bug in the naming pipeline.Severity:
mediumFile:
packages/ladle/lib/cli/vite-plugin/naming-utils.jsSolution
Replace the file ID extraction with logic that strips only the extension (last dot segment):
Changes
packages/ladle/lib/cli/vite-plugin/naming-utils.js(modified)Testing
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #637