Skip to content

Fixes #38909 - Use syslog gem not in windows #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbernhard wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixes #38909 - Use syslog gem not in windows #927

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40457c9
Fixes #38909 - Use syslog gem not in windows
sbernhard Nov 17, 2025
31830ab
Try to run the tests on windows
sbernhard Jan 6, 2026
8071fb6
Try to fix tests
sbernhard Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/smart-proxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,47 @@ jobs:
- name: Run rake test
run: bundle exec rake test

tests-on-windows:
name: "Test on Windows - Ruby ${{ matrix.ruby }}"
runs-on: windows-latest
needs:
- setup_matrix
defaults:
run:
shell: pwsh
strategy:
matrix: ${{ fromJson(needs.setup_matrix.outputs.matrix) }}
env:
BUNDLE_WITHOUT: "krb5 libvirt"
Comment on lines +82 to +83
Copy link
Copy Markdown
Member

@ekohl ekohl Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#884 may be a better way to disable installing the gems depending on the platform. Also makes the real deployment easier.

steps:
- name: Checkout this repo
uses: actions/checkout@v4
- name: Set up Ruby (Windows)
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Show Ruby env (sanity)
run: |
ruby -v
gem -v
ridk version
- name: Rake sanity
run: |
bundle exec rake -T
- name: Archive Gemfile.lock
uses: actions/upload-artifact@v4
with:
name: Gemfile-windows-ruby-${{ matrix.ruby }}.lock
path: Gemfile.lock

result:
if: always()
name: Test suite
runs-on: ubuntu-24.04
needs:
- tests
- tests-on-windows
steps:
- name: Decide whether the needed jobs succeeded or failed
uses: re-actors/alls-green@release/v1
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ end

# Changed from a default gem to a bundled gem in Ruby 3.4
# See: https://stdgems.org/new-in/3.4/
gem 'syslog' if RUBY_VERSION >= '3.4'
gem 'syslog', '>= 0.3.0' if RUBY_VERSION >= '3.4'