Skip to content

feat: Ignore top-level keys started with x- #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ilia-rassadin-rn wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Ignore top-level keys started with x- #5026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e2ea94
feat: Ignore top-level keys started with `x-`
ilia-rassadin-rn Mar 25, 2026
7a73357
Merge branch 'main' into ir-top-level-anchors
ilia-rassadin-rn Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cmd/cli/helper/read_config_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,22 @@ func readConfigFile(configFile, configFormat string) (map[string]dto.DTO, error)
if err != nil {
return nil, fmt.Errorf("%s: could not parse file (toml): %w", configFile, err)
}
return flags, nil
case "json":
err := json.Unmarshal(dat, &flags)
if err != nil {
return nil, fmt.Errorf("%s: could not parse file (json): %w", configFile, err)
}
return flags, nil
default:
// default is YAML
err := yaml.Unmarshal(dat, &flags)
if err != nil {
return nil, fmt.Errorf("%s: could not parse file (yaml): %w", configFile, err)
}
return flags, nil
}
for key := range flags {
if strings.HasPrefix(key, "x-") {
delete(flags, key)
}
}
return flags, nil
}
13 changes: 8 additions & 5 deletions testdata/flag-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,20 @@ test-flag:
description: this is a simple feature flag
issue-link: https://jira.xxx/GOFF-01

x-reusable-targeting: &x-reusable-targeting
name: rule1
query: key eq "not-a-key"
percentage:
False: 0
True: 100

test-flag2:
variations:
Default: false
False: false
True: true
targeting:
- name: rule1
query: key eq "not-a-key"
percentage:
False: 0
True: 100
- *x-reusable-targeting
defaultRule:
name: defaultRule
variation: Default
Loading