MdePkg,SecurityPkg: Fix TPM2 ACPI Table/Update to V5#12857
Open
Raymond-MS wants to merge 1 commit into
Open
Conversation
tianocore-assign-reviewers
Bot
requested review from
arunsbaskaran,
cfernald,
jyao1,
kuqin12,
lgao4 and
mdkinney
July 22, 2026 22:14
3 tasks
kuqin12
reviewed
Jul 22, 2026
Updated the ACPI code to fix an issue where the template was outdated and the revision was reporting V5 but the template was still using the V4 version of the Start Method specific parameters. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Raymond Diaz <raymonddiaz@microsoft.com>
Raymond-MS
force-pushed
the
personal/rdiaz/AcpiTableV5
branch
from
July 22, 2026 23:39
69236f8 to
35ca7b7
Compare
kuqin12
approved these changes
Jul 23, 2026
jyao1
approved these changes
Jul 23, 2026
Contributor
|
I think it is enough for V5. Will you consider V6 as well? |
cfernald
approved these changes
Jul 23, 2026
cfernald
left a comment
cfernald
left a comment
Contributor
There was a problem hiding this comment.
Looks good. thanks for making the changes mentioned in the other PR.
I think we can move forward with just V5 since that is what is needed for current support and look at v6 separately, as needed.
Contributor
Author
I can consider putting up a PR for V6 as well, for now I agree with Chris. Let's get in V5 and fix that bug that was mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the ACPI code to fix an issue where the template was outdated and the revision was reporting V5 but the template was still using the V4 version of the Start Method specific parameters.
Should address:
#12587
How This Was Tested
Ran CI locally.
Integration Instructions
N/A