Skip to content

UefiPayloadPkg: skip ConnectAll on S4 resume#12860

Open
Sean-StarLabs wants to merge 1 commit into
tianocore:masterfrom
StarLabsLtd:agent/upstream-s4-connectall
Open

UefiPayloadPkg: skip ConnectAll on S4 resume#12860
Sean-StarLabs wants to merge 1 commit into
tianocore:masterfrom
StarLabsLtd:agent/upstream-s4-connectall

Conversation

@Sean-StarLabs

Copy link
Copy Markdown
Contributor

Description

Do not globally connect devices or refresh boot options during S4 resume. Connecting removable media can change the DXE handle graph and EFI memory map from the hibernation image. Other boot modes retain the existing behavior.

This revives the second change from stale #12310 as a standalone patch.

How This Was Tested

  • PatchCheck.py
  • stuart_build for UefiPayloadPkg X64 FIT
  • Equivalent patch tested on StarBook MTL (B7-U): Linux S4 hibernate and resume with direct Universal Payload

Integration Instructions

None.

Connecting removable media during S4 resume can change the DXE handle
graph and EFI memory map from the hibernation image.

Skip the global device connection and boot-option refresh on S4 resume.
Other boot modes retain the existing behavior.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant