Added trailing slash to excluded directories#204
Open
petoc wants to merge 3 commits intotighten:3.xfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPCodeSniffer is treating paths in
ignoreoption as patterns, when passing pathbuild, paths like/build/,/builds/,/building/and so on, are all ignored, same for other default paths.As pointed out in #201, GitLab CI is by default using
/builds/directory for running jobs, so whole contents is excluded.Adding trailing slash should fix this behavior, but PHPCodeSniffer still matches paths like
/notbuild/and ignores them.So there probably should be leading slash, but this could affect other tools. This seems like reasonable hotfix.
Hopefully it will not cause any side effects.
Should fix issues #200, #201 .