Task Component Design Token#294
Open
roshan-budhathoki wants to merge 4 commits into
Open
Conversation
roshan-budhathoki
requested review from
bcha92,
kbventures and
manvinderjit
as code owners
github-actions
Bot
added
the
Frontend 💅
kbventures
requested changes
Nov 5, 2025
kbventures
left a comment
kbventures
left a comment
Contributor
There was a problem hiding this comment.
Great work. See notes.
| @@ -0,0 +1,39 @@ | |||
| import { forwardRef, type ParamHTMLAttributes } from 'react'; | |||
Contributor
There was a problem hiding this comment.
I think I brought this up in another PR of yours. Same comment. We shouldn't utilize forwardRef untless there's deliberate reason for its use not just beause it might be convinient later.
| @@ -0,0 +1,7 @@ | |||
| .taskParent { | |||
Contributor
There was a problem hiding this comment.
Would this be an opportunity to utilize our @layer component?
Deploying volunteer with
|
| Latest commit: |
ffeca3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60925d95.volunteer-ekr.pages.dev |
| Branch Preview URL: | https://design-roshan-task-component.volunteer-ekr.pages.dev |
bcha92
requested changes
Nov 13, 2025
bcha92
left a comment
bcha92
left a comment
Collaborator
There was a problem hiding this comment.
I haven't fully reviewed it yet (need to find time to manually test this on local env first) but it's the first thing I found.
| display: flex; | ||
| gap: var(--spacing-sm) 0; | ||
| align-items: center; | ||
| font-weight: bold; |
Collaborator
There was a problem hiding this comment.
please use preset value font-weight: var(--weight-bold); instead of just bold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating task component for pending and completed task.
Here, "pending" is considered as default parameter.