[fix] account for various cases of orphaned dividers#22
Open
kantorge wants to merge 1 commit intotorrobinson:masterfrom
Open
[fix] account for various cases of orphaned dividers#22kantorge wants to merge 1 commit intotorrobinson:masterfrom
kantorge wants to merge 1 commit intotorrobinson:masterfrom
Conversation
Owner
|
Thanks I appreciate the PR! Happy to hear that people are still using this and have enhancements (I've since changed jobs and moved away from this tech stack - I actually originally wrote this extension at home so I could use it at work in a certain project lol). Give me a few days to take a peek at it, as I've been busy and haven't had a chance to look yet 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some cases, when the empty header results in orphaned dividers still being rendered on the top of the list. This can happen when a conditional block is also added to the top of the list. The proposed changes account for this situation.
More specifically, the PR contains the following changes:
The main change about the divider cleanup can be best tested selecting employees from Tokyo or from any other city.
Please review the PR, and merge it if you find it useful. Let me know, if you have any questions or comments.