Skip to content

fix: use subquery for DELETE with JOINs on SQLite/PostgreSQL #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
themavik wants to merge 1 commit into from
Closed

fix: use subquery for DELETE with JOINs on SQLite/PostgreSQL #2151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tortoise/queryset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,7 +1391,19 @@ def _make_query(self) -> None:
annotations=self._annotations,
)
self.resolve_filters()
self.query._delete_from = True
if self._joined_tables:
table = self.model._meta.basetable
pk_attr = self.model._meta.pk_attr
source_pk = self.model._meta.fields_map[pk_attr].source_field or pk_attr
self.query._selects = []
self.query._select_other(Field(source_pk, table=table))
subquery = self.query
self.query = self._db.query_class.from_(table).where(
Field(source_pk, table=table).isin(subquery)
)
self.query._delete_from = True
else:
self.query._delete_from = True
return

def __await__(self) -> Generator[Any, None, int]:
Expand Down