Skip to content

feat: Front design system#600

Open
GlennTractr wants to merge 30 commits into
mainfrom
STAK-710-front-design-system
Open

feat: Front design system#600
GlennTractr wants to merge 30 commits into
mainfrom
STAK-710-front-design-system

Conversation

@GlennTractr

Copy link
Copy Markdown
Contributor

No description provided.

@GlennTractr GlennTractr requested a review from ThibautMTL March 16, 2023 14:39
@nx-cloud

nx-cloud Bot commented Mar 16, 2023

Copy link
Copy Markdown

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit cf0d94e.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

null,
);

@Input() id?: string = new Date().getTime().toString();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la variable ne sera jamais undefined si on l'initialise avec une valeur par défaut. On peut enlever l'opérateur '?'

Suggested change
@Input() id?: string = new Date().getTime().toString();
@Input() id: string = new Date().getTime().toString();


<div *ngIf="errors$ | async as errors">
<pre>
This field is invalid

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ne pas mettre de text hardcodé

(blur)="onTouched()"
[disabled]="disabled"
>
<option [value]="null">{{ placeholder || '' }}</option>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder n'est pas déclarer


<div *ngIf="errors$ | async as errors">
<pre>
This field is invalid

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ne pas mettre de text hardcodé


<div *ngIf="errors$ | async as errors">
<pre>
This field is invalid

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ne pas mettre de text hardcodé

extends BaseInputTextComponent
implements OnInit
{
@Input() placeholder?: string;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Input() placeholder?: string;
@Input() placeholder: string = 'Text';

#input
[id]="prefixId + id"
type="text"
[placeholder]="placeholder || ''"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[placeholder]="placeholder || ''"
[placeholder]="placeholder"

{
@ViewChild('textarea') textarea!: ElementRef<HTMLTextAreaElement>;

@Input() placeholder?: string;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Input() placeholder?: string;
@Input() placeholder: string = 'Textarea';

<textarea
#textarea
[id]="prefixId + id"
[placeholder]="placeholder || ''"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[placeholder]="placeholder || ''"
[placeholder]="placeholder"

#input
[id]="prefixId + id"
type="time"
[placeholder]="placeholder"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder n'est pas déclarer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants