Skip to content

feat: add helpers to check if we need to disable the global guard or not#630

Open
floross wants to merge 1 commit into
mainfrom
skip-globals-guard-if-needed
Open

feat: add helpers to check if we need to disable the global guard or not#630
floross wants to merge 1 commit into
mainfrom
skip-globals-guard-if-needed

Conversation

@floross

@floross floross commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@nx-cloud

nx-cloud Bot commented Jun 15, 2023

Copy link
Copy Markdown

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit 3b6d8a4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@codecov

codecov Bot commented Jun 15, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 27.77% and project coverage change: -0.43 ⚠️

Comparison is base (5a51c24) 64.88% compared to head (3b6d8a4) 64.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   64.88%   64.45%   -0.43%     
==========================================
  Files         254      255       +1     
  Lines        3221     3230       +9     
  Branches      674      676       +2     
==========================================
- Hits         2090     2082       -8     
- Misses       1131     1148      +17     
Flag Coverage Δ
unittests 64.45% <27.77%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nerators/service/methods/count-method.generator.ts 100.00% <ø> (ø)
...erators/service/methods/create-method.generator.ts 100.00% <ø> (ø)
...erators/service/methods/delete-method.generator.ts 100.00% <ø> (ø)
...tors/service/methods/find-many-method.generator.ts 100.00% <ø> (ø)
...rs/service/methods/find-unique-method.generator.ts 100.00% <ø> (ø)
...erators/service/methods/update-method.generator.ts 100.00% <ø> (ø)
...c/generators/service/aggregate-method.generator.ts 100.00% <ø> (ø)
...s/src/generators/service/count-method.generator.ts 100.00% <ø> (ø)
...generators/service/create-many-method.generator.ts 93.75% <ø> (ø)
.../src/generators/service/create-method.generator.ts 90.00% <ø> (ø)
... and 11 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.45%. Comparing base (5a51c24) to head (3b6d8a4).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ibs/nestjs/core/src/helpers/global-guard.helper.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   64.88%   64.45%   -0.43%     
==========================================
  Files         254      255       +1     
  Lines        3221     3230       +9     
  Branches      674      676       +2     
==========================================
- Hits         2090     2082       -8     
- Misses       1131     1148      +17     
Flag Coverage Δ
unittests 64.45% <23.52%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants