Add Ratelog app to catalog#5301
Conversation
stavros-k
left a comment
There was a problem hiding this comment.
Not exhaustive review, but it does not seem ready for review
| images: | ||
| image: | ||
| repository: ghcr.io/golmenero/ratelog | ||
| tag: latest |
| schema: | ||
| type: string | ||
|
|
||
| - variable: database |
There was a problem hiding this comment.
wrong place see other apps
| label: Port Number | ||
| schema: | ||
| type: int | ||
| default: 8080 |
There was a problem hiding this comment.
must be unique and above 30k like all other apps
| @@ -0,0 +1,3 @@ | |||
| # Ratelog | |||
|
|
|||
| [Ratelog](https://github.com/golmenero/ratelog) es una aplicación para ratear y registrar películas y series vistas. No newline at end of file | |||
| {% do app.environment.add_env("PORT", values.network.web_port.port_number) %} | ||
| {% do app.environment.add_env("TMDB_API_KEY", values.ratelog.tmdb_api_key) %} | ||
| {% do app.environment.add_env("POSTGRES_HOST", values.consts.postgres_container_name) %} | ||
| {% do app.environment.add_env("POSTGRES_PORT", 5432) %} |
| {% do app.environment.add_user_envs(values.ratelog.additional_envs) %} | ||
|
|
||
| {# Add port mappings #} | ||
| {% if not values.network.host_network %} |
| {# Setup permissions container for storage initialization #} | ||
| {% set perms = tpl.deps.perms(values.consts.perms_container_name) %} | ||
|
|
||
| {# Add PostgreSQL database #} | ||
| {% set pg_config = { | ||
| "user": values.consts.db_user, | ||
| "password": values.ratelog.db_password, | ||
| "database": values.consts.db_name, | ||
| "volume": values.storage.postgres_data, | ||
| } %} | ||
| {% set postgres = tpl.deps.postgres(values.consts.postgres_container_name, "postgres_image", pg_config, perms) %} | ||
| {% do postgres.container.add_network(ratelog_net) %} | ||
|
|
||
| {# Dependencies #} | ||
| {% do app.depends.add_dependency(values.consts.postgres_container_name, "service_healthy") %} |
There was a problem hiding this comment.
remove useless comments and follow ordering of defining everything in this file based on other apps
| {# Define the main application container #} | ||
| {% set app = tpl.add_container(values.consts.ratelog_container_name, "image") %} | ||
| {% do app.add_network(ratelog_net) %} | ||
| {% do app.set_user(568, 568) %} |
stavros-k
left a comment
There was a problem hiding this comment.
Not sure if you are doing the changes or an LLM, but there are things before that got removed now and shouldnt, like the depends_on, set_user and probably more.
This is becoming a slippery slop to review..
|
|
||
| {% set ratelog_net = tpl.networks.create_internal("ratelog-net") %} | ||
|
|
||
| {% set app = tpl.add_container(values.consts.ratelog_container_name, "image") %} |
There was a problem hiding this comment.
why not run as specific (user configurable) user?
also lacks postgres dependency.depends_on
| label: Value | ||
| schema: | ||
| type: string | ||
| - variable: postgres_image_selector |
| "database": values.consts.db_name, | ||
| "volume": values.storage.postgres_data, | ||
| } %} | ||
| {% set postgres = tpl.deps.postgres(values.consts.postgres_container_name, "postgres_image", pg_config, perms) %} |
There was a problem hiding this comment.
does not use image selector
I apologize if im not doing it properly. Im pretty new with this type of integrations. For the majority of changes what i did was specifically checking other apps. |
Specifically postgres parts are pretty much the same across the board, so I'm not sure how we ended up here. Please make sure you copy an existing app that uses the dependencies you need and adjust it. |
|
@stavros-k done. I used an existing docker compose with postgres and customized for my specific app, Hope its better at least :) |
App Addition
AI
Description
Adds ratelog to the community train. Ratelog is a self-hosted media rating application that lets you search, rate, and track movies and TV series.
App Information
Testing
Tested locally with:
All tests passed successfully.
Icons and Screenshots
Please upload the following to the CDN:
Icon:
Screenshot:
Special Notes
Checklist