Add BigQuery description length CI safeguard#1324
Draft
seamus-mckinsey wants to merge 3 commits intotuva-health:mainfrom
Draft
Add BigQuery description length CI safeguard#1324seamus-mckinsey wants to merge 3 commits intotuva-health:mainfrom
seamus-mckinsey wants to merge 3 commits intotuva-health:mainfrom
Conversation
✅ Deploy Preview for thetuvaproject canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PyYAMLPyYAMLand runs the scanner formodels,seeds, andsnapshotsWhy
This addresses the BigQuery field-description length regressions surfaced in #1323 by adding a durable CI safeguard so new over-limit metadata does not slip in unnoticed.
Validation
python3 -m unittest scripts/test_parse_ci_command.pypython3 -m venv /tmp/tuva-pyyaml-check && /tmp/tuva-pyyaml-check/bin/python -m pip install pyyaml/tmp/tuva-pyyaml-check/bin/python -m unittest scripts/test_check_metadata_description_length.py/tmp/tuva-pyyaml-check/bin/python scripts/check_metadata_description_length.py --limit 1024ruby -e 'require "yaml"; Dir[".github/workflows/*.yml"].sort.each { |path| YAML.load_file(path) }'Current violations
The scanner currently finds 10 existing descriptions over 1024 characters in input-layer YAML files. Once those are cleaned up, the workflow can be made required by removing
continue-on-error.