Lazy load EscaperRuntime in EscaperExtension#4795
Open
GromNaN wants to merge 1 commit intotwigphp:3.xfrom
Open
Lazy load EscaperRuntime in EscaperExtension#4795GromNaN wants to merge 1 commit intotwigphp:3.xfrom
EscaperRuntime in EscaperExtension#4795GromNaN wants to merge 1 commit intotwigphp:3.xfrom
Conversation
GromNaN
force-pushed
the
lazy-escaper-runtime
branch
from
69af2b7 to
7931fdd
Compare
Previously, setEnvironment() called getRuntime(EscaperRuntime::class) eagerly, which prevented overriding EscaperRuntime via a custom runtime loader since Environment::__construct() calls setEnvironment() before any loader can be injected.
GromNaN
force-pushed
the
lazy-escaper-runtime
branch
from
7931fdd to
b73ab8c
Compare
GromNaN
changed the title
EscaperRuntime in EscaperExtension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows overriding
EscaperRuntimevia a custom runtime loader.Previously,
EscaperExtension::setEnvironment()was calling$environment->getRuntime(EscaperRuntime::class)eagerly. Since this method is called fromEnvironment::__construct(), the runtime was resolved before any custom runtime loader could be injected, making it impossible to overrideEscaperRuntime.twig.safe_classresource tag to register safe classes for the escaper symfony/symfony#63929