[Doc] Reword whitespace control note about first-newline removal#4798
Open
Amoifr wants to merge 1 commit intotwigphp:3.xfrom
Open
[Doc] Reword whitespace control note about first-newline removal#4798Amoifr wants to merge 1 commit intotwigphp:3.xfrom
Amoifr wants to merge 1 commit intotwigphp:3.xfrom
Conversation
The previous wording ("inherited from PHP") was misleading: Twig does
not inherit anything from PHP, it deliberately implements the same
behavior, like Jinja does. The behavior was already explained earlier
in the same section, so just point back to it instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4720.
The wording on line 1224 of
doc/templates.rst("removal of the first newline inherited from PHP") was misleading — Twig does not inherit anything from PHP, it deliberately implements the same behavior (just like Jinja does, which uses "like in PHP" in its own documentation).The note already exists a few lines above (line 1210: "The first newline after a template tag is removed automatically (like in PHP)."), so the second mention can just point back to it instead of duplicating the (incorrect) attribution.