This repository was archived by the owner on Mar 4, 2021. It is now read-only.
Update CodeIgniter library to 2.1.4 (withdrawn)#260
Closed
frederickding wants to merge 4 commits into
Closed
Conversation
- Also applied changes to OpenVBX core files to fix compatibility - See #258
- Much better support for SMTP
- May cause issues for installations that are not being rewritten - Installation-specific options should be saved in `-local.php` config files!
Contributor
|
@frederickding at first glance this looks pretty good. However it is work done in master. OpenVBX follows uses Git-Flow to manage releases and no work goes directly in to Master. It must all go through the develop branch first. Can you merge this in to your develop branch and re-submit your pull request against our develop branch? I can certainly merge this down in to develop first, but if you can do it on your side it will speed up the process and allow me to review the changes in GitHub. |
Contributor
|
Closing in favor of #261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #258