fix archive mode usage on rules_go 0.61#304
Open
jmhodges wants to merge 1 commit into
Open
Conversation
rules_go 0.61 removed the deprecated `.go` shortcut field from the go_context struct, so `go_ctx.go.path` fails at analysis time with "'struct' value has no field or method 'go'". This access the Go binary through the SDK instead via `go_ctx.sdk.go.path`, which works on both rules_go 0.60 and 0.61+. This also matches other uses of `go_ctx.sdk.go` elsewhere in this project. Fixes uber-go#303
|
|
Contributor
Author
|
Gentle ping! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_go 0.61 removed the deprecated
.goshortcut field from thego_context struct, so
go_ctx.go.pathfails at analysis time with"'struct' value has no field or method 'go'".
This access the Go binary through the SDK instead via
go_ctx.sdk.go.path, which works on both rules_go 0.60 and 0.61+. Thisalso matches other uses of
go_ctx.sdk.goelsewhere in this project.Fixes #303