Conversation
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces namespace opt-in functionality for the object lease controller, allowing the controller to selectively manage objects based on namespace labels. The implementation adds a namespace tracker to monitor which namespaces should be included in lease management.
Key changes:
- Adds namespace-based filtering with opt-in label support
- Replaces
extended-atannotation withlease-startfor more precise lease timing control - Refactors the lease controller package structure and improves test coverage
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/util/tracker.go | New namespace tracker utility for managing opt-in namespaces with event notifications |
| pkg/controllers/namespace_controller.go | New controller for monitoring namespace label changes and updating the tracker |
| pkg/controllers/namespace_controller_test.go | Comprehensive test suite for namespace controller functionality |
| pkg/controllers/lease_controller.go | Refactored from leasewatcher package with namespace filtering and lease-start annotation |
| pkg/controllers/lease_controller_test.go | Extensive test coverage for lease controller with namespace tracking |
| cmd/main.go | Added opt-in label configuration and pprof support |
| go.mod | Made go-logr/logr a direct dependency |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
|
Pull Request closed and locked due to lack of activity. |
This PR introduces namespace opt-in functionality for the object lease controller, allowing the controller to selectively manage objects based on namespace labels. The implementation adds a namespace tracker to monitor which namespaces should be included in lease management.
Key changes:
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
Signed-off-by: Magnus Ullberg magnus@ullberg.us