Increase test coverage and refactor parseParameters to ParseParams struct#55
Merged
Increase test coverage and refactor parseParameters to ParseParams struct#55
Conversation
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
|
Pull Request closed and locked due to lack of activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request increases test coverage across the repository and refactors command-line parsing for easier testing.
Key changes:
parseParametersto return aParseParamsstruct instead of a long tuple, making the code more maintainable and test-friendly.buildManagerOptions,newLeaseWatcher, and other controller helper functions.pkg/controllers,pkg/utilto raise coverage.Notes:
maincontinues to useparseLeaderElectionConfigto validate leader election.make testcompleted successfully.