Skip to content

Preload Roboto#1189

Closed
MartinZikmund wants to merge 1 commit intomasterfrom
dev/mazi/preload-font
Closed

Preload Roboto#1189
MartinZikmund wants to merge 1 commit intomasterfrom
dev/mazi/preload-font

Conversation

@MartinZikmund
Copy link
Copy Markdown
Member

GitHub Issue (If applicable): closes https://github.com/unoplatform/uno-private/issues/1261

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Project automation
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@MartinZikmund MartinZikmund requested a review from jeromelaban May 7, 2025 14:11
@MartinZikmund MartinZikmund changed the base branch from master to canaries/dev May 7, 2025 14:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1189.eastus2.3.azurestaticapps.net

#if IS_WASM_SKIA
// Disabled https://github.com/unoplatform/uno-private/issues/777
// FontFamilyHelper.PreloadAsync("Symbols", FontWeights.Normal, Windows.UI.Text.FontStretch.Normal, Windows.UI.Text.FontStyle.Normal);
await FontFamilyHelper.PreloadAsync("ms-appx:///Uno.Fonts.Roboto/Fonts/Roboto-Regular.ttf#Roboto", FontWeights.Normal, Windows.UI.Text.FontStretch.Normal, Windows.UI.Text.FontStyle.Normal);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roboto is already set as the DefaultTextFont, which is the font that we preload. So this shouldn't be needed and it seems like it's already working, it was just a problem with canary builds I think.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed, this is not happening anymore.

@jeromelaban jeromelaban changed the base branch from canaries/dev to master May 7, 2025 18:40
@jeromelaban jeromelaban closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants