Conversation
Co-authored-by: kazo0 <4793020+kazo0@users.noreply.github.com>
|
|
|
@copilot the DotNetVersion in the CI scripts should be 10.0.100, not 10.0.200 |
Co-authored-by: kazo0 <4793020+kazo0@users.noreply.github.com>
|
|
|
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the Chefs project from .NET 9 to .NET 10 across all project files, CI/CD pipelines, and build scripts. The upgrade is comprehensive and systematic, updating target framework monikers (TFMs), SDK versions, and output paths throughout the repository.
Changes:
- Updated all project target frameworks from net9.0 to net10.0 (Chefs.csproj, Chefs.UITests.csproj, Chefs.Api.csproj)
- Updated CI/CD templates to use .NET SDK 10.0.100 (10.0.101 for WASM builds) and UnoCheck 1.33.1
- Updated all build workflows and scripts to reference net10.0 TFMs and corresponding output paths
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Chefs/Chefs.csproj | Updated TargetFrameworks from net9.0 to net10.0 for all platforms (Android, iOS, Windows, Desktop, WASM) and updated comments |
| Chefs.UITests/Chefs.UITests.csproj | Updated TargetFramework from net9.0 to net10.0 |
| Chefs.Api/Chefs.Api.csproj | Updated TargetFramework from net9.0 to net10.0 |
| crosstargeting_override.props.sample | Updated all TFM override examples from net9.0 to net10.0 |
| build/workflow/templates/dotnet-install-windows.yml | Updated DotNetVersion to 10.0.100 and UnoCheck_Version to 1.33.1 |
| build/workflow/templates/dotnet-install-mac.yml | Updated DotNetVersion to 10.0.100 and UnoCheck_Version to 1.33.1 |
| build/workflow/templates/dotnet-install-linux.yml | Updated DotNetVersion to 10.0.100 and UnoCheck_Version to 1.33.1 |
| build/workflow/templates/canary-updater.yml | Updated DotNetVersion to 10.0.100 |
| build/workflow/build-windows.yml | Updated msbuild TFM arguments and output paths from net9.0-windows10.0.19041 to net10.0-windows10.0.19041 |
| build/workflow/build-wasm.yml | Updated SDK version to 10.0.101, UnoCheck TFM to net10.0-browserwasm, and all build/output paths to net10.0-browserwasm |
| build/workflow/build-skia-desktop.yml | Updated UnoCheck TFM and all build/output paths from net9.0-desktop to net10.0-desktop |
| build/workflow/build-ios.yml | Updated UnoCheck TFM and all build/output paths from net9.0-ios to net10.0-ios |
| build/workflow/build-android.yml | Updated UnoCheck TFM and all build/output paths from net9.0-android to net10.0-android |
| build/workflow/stage-uitests-wasm.yml | Updated UnoCheck TFM and output paths from net9.0-browserwasm to net10.0-browserwasm |
| build/workflow/stage-uitests-ios.yml | Updated UnoCheck TFM from net9.0-ios to net10.0-ios |
| build/workflow/stage-uitests-android.yml | Updated UnoCheck TFM from net9.0-android to net10.0-android |
| build/scripts/wasm-uitest-run.sh | Updated all TFM references and paths from net9.0 to net10.0 |
| build/scripts/ios-uitest-run.sh | Updated UITest binary path from net9.0 to net10.0 and build TFM from net9.0-android to net10.0-android |
| build/scripts/ios-uitest-build.sh | Updated build framework from net9.0-ios to net10.0-ios |
| build/scripts/android-uitest-run.sh | Updated all APK paths and UITest binary paths from net9.0 to net10.0 |
| build/scripts/android-uitest-build.sh | Updated publish framework from net9.0-android to net10.0-android |
| Chefs/Properties/launchSettings.json | Updated Desktop WSL2 commandLineArgs path from net9.0-desktop to net10.0-desktop |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,16 +1,16 @@ | |||
| <Project Sdk="Uno.Sdk"> | |||
There was a problem hiding this comment.
The PR description states "GitHub Issue (If applicable): #" without providing an actual issue number. According to the Uno Platform contributing guidelines, every PR must reference a proper GitHub issue using the format "Fixes https://github.com/unoplatform//issues/#<ISSUE_NUMBER>", "Closes https://github.com/unoplatform//issues/#<ISSUE_NUMBER>", or "Related to https://github.com/unoplatform//issues/#<ISSUE_NUMBER>". Please provide the associated GitHub issue number in the PR description.
|
|
|
|
|
|
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Chefs projects and CI pipelines target net9.0 and pin .NET 9 SDKs, preventing net10 builds.
What is the new behavior?
Chefs targets net10.0 across projects and CI, with SDK pins moved to .NET 10.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Issue link pending — please provide the GitHub issue number.
Internal Issue (If applicable):
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.