Fix ethtool path in Wake-on-LAN documentation#498
Conversation
On Unraid 7.2.4, ethtool is installed at /usr/sbin/ethtool while /sbin/ethtool does not exist. Since this command is intended for /boot/config/go, keeping an absolute path is appropriate, but the path should be updated to /usr/sbin/ethtool.
📝 WalkthroughWalkthroughDocumentation correction to the Wake-on-LAN manual persistence instructions. The ChangesWoL Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/unraid-os/system-administration/advanced-tools/wake-on-lan.mdx`:
- Line 90: Update the translated wake-on-lan documents to match the source
command path: replace instances of "/sbin/ethtool" with "/usr/sbin/ethtool" in
each locale copy of wake-on-lan.mdx (e.g., the files under i18n/de/, i18n/fr/,
i18n/es/, i18n/ja/, i18n/zh/). Search for the literal string "/sbin/ethtool -s"
or "/sbin/ethtool" in those translation files and update them to
"/usr/sbin/ethtool -s" so the examples match the source docs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 0afd2f72-c32c-43db-a717-04b2881e61df
📒 Files selected for processing (1)
docs/unraid-os/system-administration/advanced-tools/wake-on-lan.mdx
|
|
||
| ``` | ||
| /sbin/ethtool -s eth0 wol g | ||
| /usr/sbin/ethtool -s eth0 wol g |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find all translation files with the outdated ethtool path
# Search for the old path in translation directories
rg -n '/sbin/ethtool' --glob 'i18n/**/wake-on-lan.mdx'Repository: unraid/docs
Length of output: 770
Update the ethtool path in translated WoL docs (multiple locales).
Source docs/unraid-os/system-administration/advanced-tools/wake-on-lan.mdx uses /usr/sbin/ethtool, but the wake-on-lan.mdx translations still reference /sbin/ethtool in: i18n/de/..., i18n/fr/..., i18n/es/..., i18n/ja/..., and i18n/zh/..., which will break the copied command for those users.
Expected fix for German
- /sbin/ethtool -s eth0 wol g
+ /usr/sbin/ethtool -s eth0 wol g🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/unraid-os/system-administration/advanced-tools/wake-on-lan.mdx` at line
90, Update the translated wake-on-lan documents to match the source command
path: replace instances of "/sbin/ethtool" with "/usr/sbin/ethtool" in each
locale copy of wake-on-lan.mdx (e.g., the files under i18n/de/, i18n/fr/,
i18n/es/, i18n/ja/, i18n/zh/). Search for the literal string "/sbin/ethtool -s"
or "/sbin/ethtool" in those translation files and update them to
"/usr/sbin/ethtool -s" so the examples match the source docs.
|
Thank you! |
Cloudflare PreviewPreview URL: https://pr-498.docs-efm.pages.dev |
On Unraid 7.2.4, ethtool is installed at:
/usr/sbin/ethtool
while:
/sbin/ethtool
does not exist.
As a result, the command currently documented in the Wake-on-LAN guide fails when copied directly into /boot/config/go.
This PR updates the path to match the current installation location.
Summary by CodeRabbit