-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: restore default axios request headers #7820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
j4ln
wants to merge
1
commit into
usebruno:main
Choose a base branch
from
j4ln:bugfix/default-accept-header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| const { describe, it, expect } = require('@jest/globals'); | ||
| const { makeAxiosInstance } = require('../../src/utils/axios-instance'); | ||
|
|
||
| function createStubAdapter() { | ||
| let capturedConfig = null; | ||
|
|
||
| const adapter = (config) => { | ||
| capturedConfig = config; | ||
| return Promise.resolve({ data: {}, status: 200, statusText: 'OK', headers: {}, config }); | ||
| }; | ||
|
|
||
| adapter.getConfig = () => capturedConfig; | ||
|
|
||
| return adapter; | ||
| } | ||
|
|
||
| describe('makeAxiosInstance', () => { | ||
| it('setting User-Agent does not clobber the axios default Accept header', async () => { | ||
| const stubAdapter = createStubAdapter(); | ||
| const instance = makeAxiosInstance(); | ||
|
|
||
| await instance({ url: 'https://api.example.com/test', method: 'get', adapter: stubAdapter }); | ||
|
|
||
| // axios.create() sets Accept by default; assigning a new object to defaults.headers.common | ||
| // would nuke it. Guard against that regression. | ||
| expect(stubAdapter.getConfig().headers['Accept']).toMatch(/application\/json/); | ||
| }); | ||
|
|
||
| it('sets User-Agent header to bruno-runtime version', async () => { | ||
| const stubAdapter = createStubAdapter(); | ||
| const instance = makeAxiosInstance(); | ||
|
|
||
| await instance({ url: 'https://api.example.com/test', method: 'get', adapter: stubAdapter }); | ||
|
|
||
| expect(stubAdapter.getConfig().headers['User-Agent']).toMatch(/^bruno-runtime\//); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
packages/bruno-tests/collection/echo/echo default request headers.bru
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| meta { | ||
| name: echo default request headers | ||
| type: http | ||
| seq: 14 | ||
| } | ||
|
|
||
| post { | ||
| url: {{echo-host}} | ||
| body: none | ||
| auth: none | ||
| } | ||
|
|
||
| tests { | ||
| test("sends Accept header with application/json by default", function() { | ||
| // The echo server reflects request headers back as response headers. | ||
| // Verifies that axios's default Accept header is not clobbered when | ||
| // setting User-Agent (regression for: defaults.headers.common object replacement). | ||
| const accept = res.getHeaders()["accept"]; | ||
| expect(accept).to.be.a("string"); | ||
| expect(accept).to.include("application/json"); | ||
| }); | ||
|
|
||
| test("sends User-Agent header with bruno-runtime prefix", function() { | ||
| const userAgent = res.getHeaders()["user-agent"]; | ||
| expect(userAgent).to.be.a("string"); | ||
| expect(userAgent).to.match(/^bruno-runtime\//); | ||
| }); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.