mv: fix the remaining TOCTOU#12170
Open
sylvestre wants to merge 4 commits intouutils:mainfrom
Open
Conversation
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
toctou-mv
branch
2 times, most recently
from
eb476d8 to
5104ad4
Compare
uutils#10010) EXDEV fallback now catches AlreadyExists and replaces the destination via temp-name + fs::rename. Matches GNU mv.
Add fsxattr::copy_xattrs_fd; mv's EXDEV fallback opens src/dst with O_NOFOLLOW via safe_copy and copies content + xattrs on the live fds, pinning both inodes against a concurrent renamer.
Rely on fs::copy's O_TRUNC to overwrite an existing regular file in place, like GNU mv. The symlink-destination unlink is kept.
Restore strict ENOTSUP/EOPNOTSUPP propagation on copy_xattrs and copy_xattrs_fd; add copy_xattrs_ignore_unsupported and copy_xattrs_fd_ignore_unsupported wrappers for best-effort callers. mv uses the wrappers; cp --preserve=xattr exits 1 on ENOTSUP again.
cakebaker
reviewed
May 8, 2026
Comment on lines
+2640
to
+2641
| /// and producing no diagnostic), so we report "unable to remove target" | ||
| /// instead. |
Contributor
There was a problem hiding this comment.
The we report "unable to remove target" instead part doesn't match the current behavior of the implementation as there is no such message shown (and this test doesn't check for the message).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.