Skip to content

mkfifo: drop path-based chmod to close TOCTOU race (#10020)#12174

Open
sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre:toctou-mkfifo
Open

mkfifo: drop path-based chmod to close TOCTOU race (#10020)#12174
sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre:toctou-mkfifo

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/rm/isatty (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@sylvestre sylvestre force-pushed the toctou-mkfifo branch 2 times, most recently from 170ed83 to 2fc1822 Compare May 7, 2026 06:50
@sylvestre sylvestre requested review from RenjiSann and cakebaker May 7, 2026 06:54
@sylvestre sylvestre marked this pull request as ready for review May 7, 2026 06:54
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 7, 2026

Merging this PR will improve performance by 4.12%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 312 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_long_line[10000] 424.2 µs 407.4 µs +4.12%

Comparing sylvestre:toctou-mkfifo (2fc1822) with main (d928f05)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@RenjiSann
Copy link
Copy Markdown
Collaborator

Ci is sad :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants