fix: marker, hr and img streaming animation#540
Open
shadcn wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| charCounter: { count: number; newIndex: number } | ||
| ): void => { | ||
| if (hasSkipAncestor(ancestors)) { | ||
| return; |
Contributor
There was a problem hiding this comment.
Trailing void elements (img/hr) re-animate one extra time during streaming because they never advance charCounter.count, causing a boundary collision at count === prevContentLength.
yudaprama
added a commit
to yudaprama/streamdown
that referenced
this pull request
Jul 5, 2026
… and vercel#540 PR vercel#536 and vercel#540 conflicted with the animate module refactor in PR vercel#531. This port applies their changes onto the new multi-file architecture: - Add `hr` to atomic tags for void-element animation - Stamp marker CSS custom properties on `<li>` containers - Animate task-list checkboxes via `<input>` data-sd-animate - Merge whitespace into preceding word spans inside `<a>` links - Add marker animation keyframes to styles.css - Add unit tests for marker, checkbox, hr, and link whitespace 💘 Generated with Crush Assisted-by: Crush:deepseek-v4-flash
yudaprama
added a commit
to yudaprama/streamdown
that referenced
this pull request
Jul 5, 2026
…tecture Port link whitespace merging and void-element animation from the old animate.ts into the new animate/ modules. Old files removed. Changes: - Whitespace inside <a> tags merges into preceding word span (word mode) - List markers get CSS custom property timing via applyContainerCascade - Task-list checkboxes stamped with data-sd-animate and animation style - hr added to ATOMIC_TAGS for void-element animation - Add marker keyframe animation to styles.css 💘 Generated with Crush Assisted-by: Crush:deepseek-v4-flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix issue with list markers, task-list checkboxes, images, and hr animations
Type of Change
Changes Made
::markercolor, synced to the item's first word.<img>/<hr>via the standarddata-sd-animaterule.Testing
Checklist
pnpm changeset)Changeset