Hublabel#4870
Open
electricEpilith wants to merge 104 commits into
Open
Conversation
… get a wrong answer
…bbdsg that makes labels that can fit
This reverts commit 5436d73.
…indexing test cases
Author
|
Dropped the hash tests. Moved refactor commits to |
adamnovak
requested changes
May 15, 2026
adamnovak
left a comment
adamnovak
left a comment
Member
There was a problem hiding this comment.
This looks pretty good. I found a couple places where it's not quite done and made suggestions.
I think the libbdsg changes also need to be finished, and then this needs to be made to point at the final libbdsg commit. Right now it's behind vgteam/libbdsg#239 by a few commits.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
adamnovak
requested changes
Jun 1, 2026
adamnovak
left a comment
adamnovak
left a comment
Member
There was a problem hiding this comment.
This looks pretty good now. The only thing I think we really need to change is making sure we point at the actual libbdsg commit we want.
Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The docs-job ran git submodule update in place on submodules the CI workspace left with stale origin URLs (a local mirror that is not a valid repo on the runner). deinit alone did not fix it because it leaves the cached gitdir under .git/modules/<path>, which update --init then reuses with its stale file:// origin. Remove both the working tree and the cached gitdir so each dep is re-cloned fresh from its canonical https URL, and set protocol.file.allow=never to deny local transport entirely (CVE-2022-39253) instead of the previous =always. Recurse only into libvgio, the one dep whose Doxygen INPUT needs a nested submodule tree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
Adds hub labeling functionality to the snarl distance index.