Remove vg sift (been deprecated since 2020)#4930
Open
faithokamoto wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Oh also |
Contributor
Author
|
I realized the remaining parts of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg siftis removedDescription
vg siftwas deprecated in 2020 by #3136 and has since only really been "updated" by me, when I tweaked all the subcommand files for better option parsing etc. It is at its fundamental level just a GAM filterer. We already havevg filterfor that, and indeed you could usevg filter --tsv-outplus some extra parsing to get e.g. reads with a bunch of softclips.So this ends up being a bunch of code that we don't maintain nor use, for over five years. I propose deleting it.
vg siftdepended largely on aFilterobject fromsrc/filter.cpp/.hpp, and a lot of that got tossed too. The remainder is a small collection of functions that are less filtery and more standard Alignment handling; might make more sense to hand them over to theAlignmentclass?