vg circularize tweaks#4934
Open
faithokamoto wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg circularizeDescription
I saw something that I could improve, and who's going to tell me no?
A collection of minor tweaks to
vg circularize. It was implemented over a decade ago by #281 as a minor utility and seems to have been mostly left alone.--headID was larger than the--tailID, then nothing happened but that wasn't obvious. Now we print an explicit error.--head/--tailwere used, circularizing paths by name wasn't allowed. I don't really see why that restriction should exist so I removed it.--pathcan be used multiple times, just in case that's useful.--describehere for listing path names when we already have a command purpose-built to list path names, i.e.vg paths --list.