Remove snappy dependency#4936
Open
faithokamoto wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
Okay, so removing only snappy seems to be fine. I pushed a thing that also removes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
snappyDescription
Saw in #1984 that removing the snappy dependency was suggested. RocksDB, also suggested for removal, was axed by #3137. I looked around for snappy and genuinely could not find anywhere we were using it. Deleting that submodule seemed to work fine for me. (I built from scratch etc.) I guess having the CI take a look will be the real test though.