1. fix DelimWriter constructor over a filename#251
Merged
vincentlaucsb merged 2 commits intovincentlaucsb:masterfrom Feb 18, 2026
Merged
1. fix DelimWriter constructor over a filename#251vincentlaucsb merged 2 commits intovincentlaucsb:masterfrom
DelimWriter constructor over a filename#251vincentlaucsb merged 2 commits intovincentlaucsb:masterfrom
Conversation
hirohira9119
added a commit
to hirohira9119/csv-parser
that referenced
this pull request
Oct 22, 2024
hirohira9119
added a commit
to hirohira9119/csv-parser
that referenced
this pull request
Oct 23, 2024
cherry pick and modify: /vincentlaucsb/csv-parser/pull/vincentlaucsb#251
Owner
|
Thanks for the PR and for flagging the filename ctor bug — you were absolutely on the money about the issue. I added some changes just make the lifetime semantics safe and prevent undefined behavior. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DelimWriter constructor over a filename used std::ifstream which i think it maybe a unintentional mistake?