Skip to content

Added edge case compilation tests for Windows#300

Merged
vincentlaucsb merged 10 commits intomasterfrom
mar-31-2026
Apr 1, 2026
Merged

Added edge case compilation tests for Windows#300
vincentlaucsb merged 10 commits intomasterfrom
mar-31-2026

Conversation

@vincentlaucsb
Copy link
Copy Markdown
Owner

@vincentlaucsb vincentlaucsb commented Apr 1, 2026

Compatibility Fixes

  • Makes CSV parser aware of the proprietary _MSVC_LANG macro
    • Thank you to the geniuses in Redmond who, in their infinite wisdom, decided to not define _cplusplus in non-CMake builds
  • Fixed mio.hpp narrowing conversion warning for strict Windows builds
  • Created a edge-case CI workflow containing Windows non-CMake MSVC and MinGW builds
  • Code coverage bumped from 89% -> 91% (no test failures)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.95%. Comparing base (46b7c5b) to head (26970fc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   88.91%   90.95%   +2.04%     
==========================================
  Files          23       23              
  Lines        1515     1515              
  Branches      617      617              
==========================================
+ Hits         1347     1378      +31     
+ Misses         66       42      -24     
+ Partials      102       95       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/msvc-consumer-compat.yml Fixed
Comment thread .github/workflows/compat-edge-cases.yml Fixed
Comment thread .github/workflows/compat-edge-cases.yml Fixed
Comment thread .github/workflows/compat-edge-cases.yml Fixed
Comment thread .github/workflows/compat-edge-cases.yml Fixed
submodules: recursive

- name: Set up MSYS2 (MinGW64)
uses: msys2/setup-msys2@v2

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Compatibility Edge Cases' step
Uses Step
uses 'msys2/setup-msys2' with ref 'v2', not a pinned commit hash
vincentlaucsb and others added 4 commits March 31, 2026 18:38
…ain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Also added tests + documentation
sha256sum csv.hpp > csv.hpp.sha256

- name: Upload release assets
uses: softprops/action-gh-release@v2

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Release Single Header Asset' step
Uses Step
uses 'softprops/action-gh-release' with ref 'v2', not a pinned commit hash
Comment thread tests/test_csv_field.cpp Dismissed
Comment thread tests/test_csv_field.cpp Dismissed
Comment thread tests/test_write_csv.cpp Dismissed
submodules: recursive

- name: Set up MSVC developer command prompt
uses: ilammy/msvc-dev-cmd@v1

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Compatibility Edge Cases' step
Uses Step
uses 'ilammy/msvc-dev-cmd' with ref 'v1', not a pinned commit hash
Comment thread tests/test_guess_csv.cpp Dismissed
@vincentlaucsb vincentlaucsb changed the title Add test for MSVC compilation w/o CMake Added edge case compilation tests Apr 1, 2026
@vincentlaucsb vincentlaucsb changed the title Added edge case compilation tests Added edge case compilation tests for Windows Apr 1, 2026
@vincentlaucsb vincentlaucsb merged commit c4883c7 into master Apr 1, 2026
21 checks passed
@vincentlaucsb vincentlaucsb deleted the mar-31-2026 branch April 1, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants