Skip to content

Softwrap helper text below repo field in create environment form #11228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zachbai wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −6
Draft

Softwrap helper text below repo field in create environment form #11228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions app/src/settings_view/update_environment_form.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2322,6 +2322,7 @@ impl UpdateEnvironmentForm {
appearance.ui_font_family(),
appearance.ui_font_size() * 0.85,
)
.soft_wrap(true)
.with_color(theme.nonactive_ui_text_color().into())
.finish();

Expand All @@ -2335,14 +2336,13 @@ impl UpdateEnvironmentForm {
// "Missing a repo? Configure access on GitHub" text with link
let install_link = app_install_link.clone();

// Build as a row with plain text + link
let mut text_row = Flex::row()
// Build "Missing a repo?" + link as an inner row
let mut missing_repo_row = Flex::row()
.with_cross_axis_alignment(CrossAxisAlignment::Center)
.with_spacing(4.);

text_row.add_child(helper);
// Plain text part
text_row.add_child(
missing_repo_row.add_child(
Text::new(
"Missing a repo?",
appearance.ui_font_family(),
Expand Down Expand Up @@ -2377,9 +2377,16 @@ impl UpdateEnvironmentForm {
})
.finish();

text_row.add_child(link);
missing_repo_row.add_child(link);

text_row.finish()
// Stack helper text and "Missing a repo?" row in a column so the
// helper text can softwrap without truncating the link.
Flex::column()
.with_cross_axis_alignment(CrossAxisAlignment::Stretch)
.with_spacing(2.)
.with_child(helper)
.with_child(missing_repo_row.finish())
.finish()
}

#[cfg(target_family = "wasm")]
Expand Down