Fix diff footer overflow on narrow panes#11237
Draft
moirahuang wants to merge 1 commit into
Draft
Conversation
Use a compact icon-only variant for diff hunk navigation controls when the footer is rendered in narrow panes so the Next label cannot overflow. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the diff footer layout at narrow pane widths by switching the hunk navigation controls to compact icon-only Previous/Next buttons below a width threshold. This keeps the existing labeled controls at normal widths while preventing the "Next" text from overflowing in narrow panes.
Linked Issue
ready-to-specorready-to-implement.Slack report: diff footer "Next" text overflows on narrow pane widths.
Testing
rustfmt --edition 2021 /workspace/warp/app/src/code/editor/nav_bar.rscargo check --manifest-path /workspace/warp/Cargo.toml -p warp --lib(passes with existing unrelated unused-variable warnings)I have manually tested my changes locally with
./script/runScreenshots / Videos
Not attached; this sandbox does not support running the full GUI locally.
Agent Mode
CHANGELOG-BUG-FIX: Fixed diff footer navigation text overflowing in narrow panes.
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/a995ab5c-cee6-485d-b953-9a16e57a3f79
Run: https://oz.staging.warp.dev/runs/019e3d16-c5a3-7ab0-9aa8-b6606a78855a
This PR was generated with Oz.