Fix compact reject hover affordance#11239
Draft
moirahuang wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes compact inline action headers so the reject affordance hover background includes both the status icon (yellow square) and the
Xicon.In compact mode, the header status icon is now rendered as part of the first compact action button group and shares that button's mouse state. The regular/full-width header layout is unchanged.
Linked Issue
Slack feedback: "the hover of this reject button should always include both the yellow square and the x"
ready-to-specorready-to-implement.Testing
cargo check --manifest-path /workspace/warp/Cargo.toml -p warp --lib./script/runrustfmtwas not available in the sandbox toolchain (rustfmtcomponent missing), so file-level formatting could not be run here.Screenshots / Videos
Not captured in this sandbox.
Agent Mode
CHANGELOG-BUG-FIX: Fixed the compact reject affordance hover state so it includes both the yellow status square and the X icon.
Conversation: https://staging.warp.dev/conversation/95ed4c30-6aaf-43eb-8ab0-37c2ba9c3123
Run: https://oz.staging.warp.dev/runs/019e3d16-6e71-7db7-9e62-a74f85887545
Co-Authored-By: Oz oz-agent@warp.dev
This PR was generated with Oz.