-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix stale git diff chip and code review button #11242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4813,6 +4813,10 @@ impl TerminalView { | |
| self.input.update(ctx, |input, ctx| { | ||
| input.update_repo_path(None, ctx); | ||
| }); | ||
| // Redraw on repo exit so the code review button drops its diff annotation immediately. | ||
| self.refresh_pane_header(ctx); | ||
| ctx.emit(Event::TerminalViewStateChanged); | ||
| ctx.notify(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense to me that we emit a
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the call out! No need to refresh the pane header here, and also re-rendering the active terminal view is also redundant ( |
||
| } | ||
|
|
||
| /// Helper to read metadata from the per-repo sub-model. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!