Fix scrollable dropdown menu background#11244
Draft
ianhodge wants to merge 1 commit into
Draft
Conversation
Use the menu surface fill for scrollable menu content so dropdowns render with an opaque background instead of allowing controls underneath to show through. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the menu surface fill for scrollable menu content instead of
Fill::None, so dropdowns render an opaque themed background and do not allow controls underneath to bleed through.This fixes the New API key modal dropdown path and applies consistently to shared scrollable menus.
Linked Issue
Slack thread: "New API key dropdown needs a background."
ready-to-specorready-to-implement.Testing
cargo fmt --all --manifest-path /workspace/warp/Cargo.toml --checkcargo check --manifest-path /workspace/warp/Cargo.toml -p warp --bin warp-osscargo build --manifest-path /workspace/warp/Cargo.toml -p warp --bin warp-osscargo build --manifest-path /workspace/warp/Cargo.toml -p warp --bin dev --features skip_loginCARGO_BUILD_JOBS=1 cargo test --manifest-path /workspace/warp/Cargo.toml -p warp menu --lib— 165 passedAttempted
cargo clippy --manifest-path /workspace/warp/Cargo.toml --workspace --all-targets --all-features --tests -- -D warnings; it is currently blocked by existing warnings-as-errors inwarpui_corebefore reaching this change.Computer use: launched the native dev client with
skip_login, opened Settings → Cloud platform → Oz Cloud API Keys → New API key. The test account had no agents, so the Agent selector rendered its empty state; the Expiration dropdown, which uses the same shared scrollable menu path, rendered with an opaque background and no bleed-through.I have manually tested my changes locally with
./script/runScreenshots / Videos
Not attached; verified with computer use in the sandbox.
Agent Mode
CHANGELOG-BUG-FIX: Fixed scrollable dropdown menus, including the New API key modal dropdown, rendering without an opaque background.
Conversation: https://staging.warp.dev/conversation/74ab9246-dfad-4521-8cf2-9b7cb01a1bd6
Run: https://oz.staging.warp.dev/runs/019e3d33-f739-7a3c-bd7d-3e78fc503c34
This PR was generated with Oz.