[QUALITY-662] Fix orchestration pill hover contrast to match Figma#11246
[QUALITY-662] Fix orchestration pill hover contrast to match Figma#11246advait-m wants to merge 1 commit into
Conversation
The pill bar was rendering child pills with neutral_2/neutral_3, which pre-blend the overlay against pure theme.background(). But the pill bar sits on the agent-view surface (surface_overlay_1), so the painted color was darker than the Figma spec called for and the rest->hover contrast bump barely read. Switch to composing fg_overlay_2 (rest) and fg_overlay_3 (hover) over agent_view_bg_color and resolving to a solid so the avatar cutout ring keeps matching the painted pill exactly. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates orchestration child pill rest and hover backgrounds to compose fg_overlay_2/fg_overlay_3 over the agent-view surface instead of using neutral colors pre-blended against the global background. The selected and selected-hover paths remain unchanged, and the PR description includes before/after screenshots for the user-facing visual change.
Concerns
- No blocking concerns found.
- No approved spec context was available, so there was no material spec requirement to compare beyond the PR description.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Before:
After:
Description
Fixes QUALITY-662: the orchestration pill bar's child pills were not visibly responding to hover, and the rest colors looked darker than the Figma spec.
The pills were using
neutral_2/neutral_3, which pre-blend the overlay against puretheme.background(). But the pill bar sits on the agent-view surface (surface_overlay_1), so the painted color came out darker than spec and the rest→hover contrast bump barely read.Switched to composing
fg_overlay_2(rest) andfg_overlay_3(hover) overagent_view_bg_color, then resolving to a solid so the avatar cutout ring still matches the painted pill exactly. Matches the Figma spec.Selected and selected-hover paths are unchanged (already use
theme.foreground()per spec).Fixes https://linear.app/warpdotdev/issue/QUALITY-662/improve-hover-contrast-on-pill-buttons
Co-Authored-By: Oz oz-agent@warp.dev