fix: surface detailed GitHub auth errors#11248
Draft
captainsafia wants to merge 2 commits into
Draft
Conversation
Render the server-provided GitHub authentication error message in cloud-mode auth surfaces instead of always falling back to a generic missing-auth copy. Co-Authored-By: Oz <oz-agent@warp.dev>
Constrain Cloud Mode GitHub auth and setup error messages so long server-provided copy stays within the pane/card layout without changing the displayed text. Co-Authored-By: Oz <oz-agent@warp.dev>
captainsafia
force-pushed
the
oz-agent/github-auth-error-messages
branch
from
8d471e5 to
4ad168a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Render the server-provided GitHub auth failure message in cloud-mode GitHub auth surfaces instead of always showing the generic “Missing GitHub authentication.” copy.
This lets the app show more specific failures such as a connected GitHub account missing access to repos defined by the selected environment.
Linked Issue
ready-to-specorready-to-implement.Slack thread: D0AU96L8CDV / 1779148608.734439
Testing
cargo test --manifest-path /workspace/warp/Cargo.toml -p warp github_auth_url_for_initial_run_includes_focus_cloud_mode_next./script/runScreenshots / Videos
Not captured; this PR changes copy rendering for an existing auth error state and is paired with a server PR that supplies the specific messages.
Agent Mode
Conversation: https://staging.warp.dev/conversation/e3ac34bc-4985-48fc-bd92-970fd4be91aa
Run: https://oz.staging.warp.dev/runs/019e3d85-5d38-72b4-b0ed-18430632414f
This PR was generated with Oz.