[WFCORE-7544] Fix usability issue renaming installation-manager.sh to…#6706
Open
yersan wants to merge 1 commit into
Open
[WFCORE-7544] Fix usability issue renaming installation-manager.sh to…#6706yersan wants to merge 1 commit into
yersan wants to merge 1 commit into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
… ./installation/_installation-manager_helper.sh Jira issue: https://redhat.atlassian.net/browse/WFCORE-7544 Signed-off-by: Yeray Borges <yborgess@redhat.com>
yersan
commented
May 19, 2026
| <!-- Unstable API Annotation Index --> | ||
| <package name="org.wildfly._internal.unstable-api-annotation-index" optional="true" valid-for-stability="preview" /> | ||
| <package name="org.wildfly.unstable.annotation.api.indexer" optional="true" valid-for-stability="preview" /> | ||
| <package name=".installation"/> |
Contributor
Author
There was a problem hiding this comment.
@jfdenise We are adding this new .installation directory under the standard galleon content directory, so I understand there is an auto discovery done by Galleon and a new package, named ".installation" is created out of the box.
My question is more about design than functionality. Under which circumstances should we count on this auto discovery of package names instead of creating our own dedicated package name?
I only can think of having a maybe better package name, but I am not sure
|
Core -> Full Integration (with SecurityManager) Build 15454 outcome was FAILURE using a merge of 7f9fdca Failed tests |
|
Core -> Full Integration Build 15128 outcome was FAILURE using a merge of 7f9fdca Failed tests |
|
Core -> WildFly Preview Integration Build 132 outcome was FAILURE using a merge of 7f9fdca Failed tests |
|
Core -> Full Integration (with SecurityManager) Build 131 outcome was FAILURE using a merge of 7f9fdca Failed tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… _installation-manager_helper.sh
Jira issue: https://redhat.atlassian.net/browse/WFCORE-7544