This repository was archived by the owner on Jan 27, 2020. It is now read-only.
Create FingerprintDiffer#9
Closed
JeroenDeDauw wants to merge 1 commit into
Closed
Conversation
Story: https://phabricator.wikimedia.org/T220150 Usage would be something like #8 Might want to put this in a more general Wikibase library, though putting it here to start to avoid needing to wait forever to get though the whole MW vendor.git process.
Contributor
|
1- We are not supposed to work on doctrine 2- Fingerprint is a general class that we should avoid using it's amorphous |
Contributor
Author
|
Amir, I get that you don't want Doctrine to happen, but please stop pointing that out in every comment you write. We already know. This is also the 20th(?) time you mention Fingerprint is bad. You had yet to under-build that point. Refusing to talk about it and repeating it everywhere is not cool. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story: https://phabricator.wikimedia.org/T220150
Usage would be something like #8
Might want to put this in a more general Wikibase library,
though putting it here to start to avoid needing to wait
forever to get though the whole MW vendor.git process.