Skip to content

fix(llm-transformer): remove unwanted template params from guardrail policies #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sithumli wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(llm-transformer): remove unwanted template params from guardrail policies #1689

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3db035
fix(llm-transformer): remove unwanted template params from guardrail …
Sithumli Apr 13, 2026
543f7fe
fix(llm-transformer): ensure user-defined policies do not include tem…
Sithumli Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions gateway/gateway-controller/pkg/utils/llm_transformer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,14 +269,10 @@ func (t *LLMProviderTransformer) transformProxy(proxy *api.LLMProxyConfiguration
operationRegistry[targetKey] = targetOp
}

templateParams, err := buildTemplateParams(tmpl, targetPath)
if err != nil {
return nil, fmt.Errorf("failed to build template params: %w", err)
}
pol := api.Policy{
Name: llmPol.Name,
Version: llmPol.Version,
Params: mergeParams(pathEntry.Params, templateParams),
Params: copyParams(pathEntry.Params),
}
Comment thread
Sithumli marked this conversation as resolved.
appendOperationPolicy(targetOp, pol)
attachedPolicyPaths[targetPath] = true
Expand Down Expand Up @@ -510,14 +506,10 @@ func (t *LLMProviderTransformer) transformProvider(provider *api.LLMProviderConf
continue
}

templateParams, err := buildTemplateParams(tmpl, targetPath)
if err != nil {
return nil, fmt.Errorf("failed to build template params: %w", err)
}
pol := api.Policy{
Name: llmPol.Name,
Version: llmPol.Version,
Params: mergeParams(pathEntry.Params, templateParams),
Params: copyParams(pathEntry.Params),
}
appendOperationPolicy(targetOp, pol)
attachedPolicyPaths[targetPath] = true
Expand Down Expand Up @@ -615,14 +607,10 @@ func (t *LLMProviderTransformer) transformProvider(provider *api.LLMProviderConf
operationRegistry[targetKey] = targetOp
}

templateParams, err := buildTemplateParams(tmpl, targetPath)
if err != nil {
return nil, fmt.Errorf("failed to build template params: %w", err)
}
pol := api.Policy{
Name: llmPol.Name,
Version: llmPol.Version,
Params: mergeParams(pathEntry.Params, templateParams),
Params: copyParams(pathEntry.Params),
}
appendOperationPolicy(targetOp, pol)
attachedPolicyPaths[targetPath] = true
Expand Down Expand Up @@ -793,6 +781,19 @@ func mergeParams(base map[string]interface{}, extra map[string]interface{}) *map
return &merged
}

// copyParams creates a shallow copy of the parameters map and returns a pointer to it.
// Returns nil if the input map is nil or empty.
func copyParams(params map[string]interface{}) *map[string]interface{} {
if len(params) == 0 {
return nil
}
copied := make(map[string]interface{}, len(params))
for k, v := range params {
copied[k] = v
}
return &copied
}
Comment on lines +784 to +795
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New helper copyParams and the behavioral change (policies should no longer receive template extraction keys like requestModel/promptTokens/etc.) aren’t covered by unit tests. Since this package already has tests for related helpers (buildTemplateParams/mergeParams), add tests for copyParams and a transformer-level test asserting that attached policies only include user-provided params (and not template extraction fields).

Copilot uses AI. Check for mistakes.

func appendOperationPolicy(op *api.Operation, pol api.Policy) {
if op.Policies == nil {
op.Policies = &[]api.Policy{pol}
Expand Down
Loading