fix(deps): upgrade eslint and plugins to 9.39.4 by maxkoryukov · Pull Request #201701 · wwebjs/whatsapp-web.js

maxkoryukov · 2026-04-07T00:17:47Z

Description

This PR changes (I hope) nothing in the package's code, but it upgrades the eslint to the newest v10.2.0 with the flat config structure.

Testing Summary

I converted the old .eslintrc.json and .eslintignore files into the newer "flat" format of eslint config - eslint.config.mjs.

.mjs for the config file - because today it is very common to share/copy/paste eslint configs and examples in ESM format.

In order to test - i took my previous PRs "as is" and applied npm run lint:fix - and the new 10.2.0 eslint fixed the code.

I've added @stylistic plugin as well, with its "recommended" config. Because of notes in the migration guide

ESLint has officially deprecated all built-in formatting and stylistic rules as of version 8.53.0

The "Prettier" integration is preserved, and as its documentation says - it is added to the end of the "flat" config (this way "Prettier" config overrides some options and make Eslint and Prettier work harmoniously)

Type of Change

Dependency change (package changes such as removals, upgrades, or additions)
Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Non-code change (documentation, README, etc.)

Checklist

My code follows the style guidelines of this project.
All new and existing tests pass (npm test).
Typings (e.g. index.d.ts) have been updated if necessary.
Usage examples (e.g. example.js) / documentation have been updated if applicable.

SUMMARY

branch is updated
eslint is stable (9.39.4), it uses the new "flat" config
no @stylistic in favour of prettier
i reproduced the old config in the "flat"-style as accurate as i could
mocha plugin updated, and it is configured only for the /tests folder
languageOptions.ecmaVersion is set to 2025
in github actions/lint: node upgraded to v24, actions upgraded to the latest version

unrelated changes:

is-ci - NPM sort packages in "./package.json::dependencies" in the lexicographical order, so it moved down in the list
i've added several " " spaces in comments after //. No logic affected, i think i did it after i applied @stylistic - but now it is disabled
i added only one pattern for "unused" variables - ^ignoredError , in practice it is nice to have another pattern, like "__", but the package didn't have any - so i copied the config

maxkoryukov · 2026-04-07T19:26:41Z

@2hoch1 thanks for reviewing so fast! and thanks for adding the #201702 (stale deps) - i didn't notice this bug

and i've downgraded eslint to @9.39.4

in order to test i put this whole repo into a "node:24" docker image without eslint pre-installed, ran npm i , ensured that npm run lint -- --version returns

eslint
9.39.4

and checked the linting output.

after fixing minor issues (some // eslint ignore aren't required for eslint@9), the linter stopped to show warnings - and i pushed the PR for a new review.

2hoch1 · 2026-04-07T20:24:20Z

Your changes to lint.yml are blocking the ESLint workflow. Reverting the change should fix it.

maxkoryukov · 2026-04-07T20:30:31Z

Your changes to lint.yml are blocking the ESLint workflow. Reverting the change should fix it.

without this changes the Action fails, and the whole PR is considered "failing"

but let me remove those changes from the PR

UPD: DONE

maxkoryukov · 2026-04-07T20:39:38Z

so, yes, i rolled back changes in the "gitlab actions" and now the "Lint/ Eslint(pull_request)" Check fails in the GH Actions

Error, it was only to approve workflow

2hoch1 · 2026-04-07T21:02:18Z

Your workflow didn’t run because you are a first‑time contributor.

The current error is caused by the lint.yml setup, since that workflow still uses Node@14 while @stylistic/eslint-plugin requires Node@18. That is why the tests workflow is passing but the lint workflow is failing.

You can try adjusting the lint.yml. The bump is in fact necessary, even if the workflow gets removed afterward.

maxkoryukov · 2026-04-08T04:26:48Z

Your workflow didn’t run because you are a first‑time contributor.

The current error is caused by the lint.yml setup, since that workflow still uses Node@14 while @stylistic/eslint-plugin requires Node@18. That is why the tests workflow is passing but the lint workflow is failing.

You can try adjusting the lint.yml. The bump is in fact necessary, even if the workflow gets removed afterward.

yep, I went through this whole process lint.yaml - broken - fixed - restricted - ...

So, i'm going to push that sent... lost, found, subjected to public inquiry, lost again, and finally buried in soft peat commit back ;)

the pipeline will be in the "unapproved changes"-state, that's completely out of my control - i don't need it, but the maintainers' help and participation will be required to resolve this.

Also: it is not @stylistic/.. that fails, it is espree (the core part of eslint). And even eslint 9.39.4 requires at least Node v18.18 - so removing @stylistic won't resolve this issue with GH Actions.

2hoch1 · 2026-04-16T10:56:51Z

Make the following changes before merge:

Scope Mocha to the test folder only
Update ecmaVersion to 2025

The args: 'all' issue will be fixed in the future and shouldn't be included in this pr.

maxkoryukov · 2026-04-16T22:25:25Z

i'm updating :

ecmaVersion for eslint config
limit the scope for "mocha" plugin
updating the branch

maxkoryukov · 2026-04-16T23:22:25Z

SUMMARY

branch is updated
eslint is stable (9.39.4), it uses the new "flat" config
no @stylistic in favour of prettier
i reproduced the old config in the "flat"-style as accurate as i could
mocha plugin updated, and it is configured only for the /tests folder
languageOptions.ecmaVersion is set to 2025
in github actions/lint: node upgraded to v24, actions upgraded to the latest version

unrelated changes:

is-ci - NPM sort packages in "./package.json::dependencies" in the lexicographical order, so it moved down in the list
i've added several " " spaces in comments after //. No logic affected, i think i did it after i applied @stylistic - but now it is disabled
i added only one pattern for "unused" variables - ^ignoredError , in practice it is nice to have another pattern, like "__", but the package didn't have any - so i copied the config

2hoch1 · 2026-04-17T14:13:33Z

LGTM

purpshell · 2026-04-17T18:15:24Z

@maxkoryukov Please update the branch.

because it is linting (not runtime), so why not to use the latest stable Node version

for example `describe` is not considered "global" outside the test files. the same for all other "eslint/mocha" rules - they are applied only to files in `/tests` folder.

maxkoryukov · 2026-04-18T19:57:21Z

@purpshell - the branch is updated

SUMMARY

branch is updated
eslint is stable (9.39.4), it uses the new "flat" config
no @stylistic in favour of prettier
i reproduced the old config in the "flat"-style as accurate as i could
mocha plugin updated, and it is configured only for the /tests folder
languageOptions.ecmaVersion is set to 2025
in github actions/lint: node upgraded to v24, actions upgraded to the latest version
NEW: package-lock.json is updated

unrelated changes:

is-ci - NPM sort packages in "./package.json::dependencies" in the lexicographical order, so it moved down in the list
i've added several " " spaces in comments after //. No logic affected, i think i did it after i applied @stylistic - but now it is disabled
i added only one pattern for "unused" variables - ^ignoredError , in practice it is nice to have another pattern, like "__", but the package didn't have any - so i copied the config

github-actions Bot added dependencies Dependency updates api changes API modifications tests Test related build Build system utility Utility code labels Apr 7, 2026

maxkoryukov commented Apr 7, 2026

View reviewed changes

Comment thread src/authStrategies/BaseAuthStrategy.js

maxkoryukov commented Apr 7, 2026

View reviewed changes

Comment thread src/Client.js Outdated

maxkoryukov commented Apr 7, 2026

View reviewed changes

Comment thread tests/structures/chat.js

github-actions Bot added ci CI pipeline infra Infrastructure labels Apr 7, 2026

maxkoryukov commented Apr 7, 2026

View reviewed changes

Comment thread .github/workflows/lint.yml

2hoch1 reviewed Apr 7, 2026

View reviewed changes

Comment thread package.json Outdated

2hoch1 mentioned this pull request Apr 7, 2026

chore: bump stale dependencies #201702

Merged

9 tasks

maxkoryukov force-pushed the feat/deps-upgrade-eslint-10.mk branch from 4db9fb4 to 38b8177 Compare April 7, 2026 19:10

maxkoryukov force-pushed the feat/deps-upgrade-eslint-10.mk branch from 38b8177 to 1b099ce Compare April 7, 2026 20:31

github-actions Bot removed ci CI pipeline infra Infrastructure labels Apr 7, 2026

maxkoryukov changed the title ~~fix(deps): upgrade eslint and plugins to 10.2.0~~ fix(deps): upgrade eslint and plugins to 9.39.4 Apr 7, 2026

BenyFilho previously approved these changes Apr 7, 2026

View reviewed changes

BenyFilho added the approved Confirmed by maintainers label Apr 7, 2026

BenyFilho removed the approved Confirmed by maintainers label Apr 7, 2026

2hoch1 reviewed Apr 7, 2026

View reviewed changes

Comment thread eslint.config.mjs Outdated

github-actions Bot added the ci CI pipeline label Apr 8, 2026

tuyuribr requested changes Apr 16, 2026

View reviewed changes

Comment thread .github/workflows/lint.yml

Comment thread package.json

purpshell requested changes Apr 16, 2026

View reviewed changes

Comment thread package.json

Comment thread .github/workflows/lint.yml

Comment thread .github/workflows/lint.yml

Comment thread src/authStrategies/BaseAuthStrategy.js

BenyFilho added the approved Confirmed by maintainers label Apr 16, 2026

maxkoryukov force-pushed the feat/deps-upgrade-eslint-10.mk branch from ad7b03c to 931339d Compare April 16, 2026 23:06

maxkoryukov requested review from purpshell and tuyuribr April 16, 2026 23:07

2hoch1 approved these changes Apr 17, 2026

View reviewed changes

tuyuribr approved these changes Apr 17, 2026

View reviewed changes

Comment thread .github/workflows/lint.yml

BenyFilho approved these changes Apr 17, 2026

View reviewed changes

purpshell approved these changes Apr 17, 2026

View reviewed changes

purpshell enabled auto-merge (squash) April 17, 2026 18:15

purpshell disabled auto-merge April 17, 2026 18:16

maxkoryukov added 8 commits April 18, 2026 15:41

fix(deps): upgrade eslint and plugins to 10.2.0

9993465

chore: manual lint-fix

0c009e4

chore: automatic lint-fix

f20de2b

feat(repo): github actions - lint - use node v24

34a6146

because it is linting (not runtime), so why not to use the latest stable Node version

fix: remove @stylistic/eslint-plugin (in favor of prettier)

a8de777

fix: eslint uses ecmaVersion 2025

9eb9709

fix: eslint's "mocha" config is isolated (for test files only)

4581b05

for example `describe` is not considered "global" outside the test files. the same for all other "eslint/mocha" rules - they are applied only to files in `/tests` folder.

chore: update package-lock.json after eslint upgrade

24da8d6

maxkoryukov force-pushed the feat/deps-upgrade-eslint-10.mk branch from 931339d to 24da8d6 Compare April 18, 2026 19:55

BenyFilho merged commit 2112053 into wwebjs:main Apr 18, 2026
4 checks passed

maxkoryukov deleted the feat/deps-upgrade-eslint-10.mk branch April 19, 2026 12:29

maxkoryukov restored the feat/deps-upgrade-eslint-10.mk branch April 19, 2026 12:31

Uh oh!

Conversation

maxkoryukov commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing Summary

Type of Change

Checklist

SUMMARY

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxkoryukov commented Apr 7, 2026

Uh oh!

2hoch1 commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxkoryukov commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxkoryukov commented Apr 7, 2026

Uh oh!

2hoch1 commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

maxkoryukov commented Apr 8, 2026

Uh oh!

2hoch1 commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxkoryukov commented Apr 16, 2026

Uh oh!

maxkoryukov commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

Uh oh!

2hoch1 commented Apr 17, 2026

Uh oh!

Uh oh!

purpshell commented Apr 17, 2026

Uh oh!

maxkoryukov commented Apr 18, 2026

SUMMARY

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

maxkoryukov commented Apr 7, 2026 •

edited

Loading

2hoch1 commented Apr 7, 2026 •

edited

Loading

maxkoryukov commented Apr 7, 2026 •

edited

Loading

2hoch1 commented Apr 7, 2026 •

edited

Loading

2hoch1 commented Apr 16, 2026 •

edited

Loading

maxkoryukov commented Apr 16, 2026 •

edited

Loading