Fix activity loading render loop#1321
Merged
Merged
Conversation
Keep derived activity entries and fallback chain IDs referentially stable while facets are loading. Add a regression test covering repeated renders before facet data arrives.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
w84april
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where, when new activity rows were being loaded, the page was preventing any further actions outside the activity component. Navigation was blocked and required waiting or reloading.
Fix:
Root cause
While the activity facets request was pending, the hook recreated its fallback chain ID array on every render. The Activity section watched that array by reference and wrote it into state, producing a maximum-update-depth loop that could block navigation and other interactions until the facets request completed.
Impact
The Activity tab remains responsive while additional activity pages and facet data are loading.
Validation
bunx vitest run src/components/pages/portfolio/hooks/usePortfolioActivity.test.tsxbun run tslintbun run lint:fixbun run buildLoading more...was visible